Add test for Plugin::ConfigStr() #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youhy <haoyuan2019@outlook.com>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #447 +/- ##
============================================
+ Coverage 67.81% 69.32% +1.50%
============================================
Files 29 29
Lines 3281 3276 -5
============================================
+ Hits 2225 2271 +46
+ Misses 1056 1005 -51
Help us with your feedback. Take ten seconds to tell us how you rate us. |
chapulina
reviewed
Jul 29, 2022
Signed-off-by: youhy <haoyuan2019@outlook.com>
jennuine
reviewed
Aug 1, 2022
There was a problem hiding this comment.
Let's go ahead and wrap this in LCOV_EXCL_START/STOP as well:
Lines 365 to 366 in e0acd4a
Signed-off-by: youhy <haoyuan2019@outlook.com>
|
@osrf-jenkins run tests please |
jennuine
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youhy haoyuan2019@outlook.com
New feature
Summary
Add test for
Plugin::ConfigStr()Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.